Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MLX): add Semantic search preview #772

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

paulgerold
Copy link
Contributor

Add the semantic search preview :

https://platformdev.cloud.coveo.com/docs?urls.primaryName=Machine%20Learning%20Configuration#/Semantic%20Search%20Configuration/rest_organizations_paramId_machinelearning_configuration_ses_preview_post

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@paulgerold paulgerold marked this pull request as ready for review November 18, 2023 01:36
@paulgerold paulgerold requested a review from a team November 18, 2023 01:36
@paulgerold paulgerold requested a review from a team as a code owner November 18, 2023 01:36
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly have docs-related comments / questions. If you choose to apply my comments, you should also update the Swagger docs accordingly.

@JTangCoveo JTangCoveo self-requested a review November 21, 2023 15:34
@paulgerold paulgerold merged commit 4dc7e3c into master Nov 21, 2023
4 checks passed
@paulgerold paulgerold deleted the MLX-765-update-platform-client-to-add-ses-preview branch November 21, 2023 19:50
Copy link

🎉 This PR is included in version 49.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants