Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ngsp): add POST /manifest #790

Merged
merged 2 commits into from
Feb 5, 2024
Merged

feat(ngsp): add POST /manifest #790

merged 2 commits into from
Feb 5, 2024

Conversation

louis-bompart
Copy link
Contributor

@louis-bompart louis-bompart commented Jan 18, 2024 •
edited
Loading

https://coveord.atlassian.net/browse/CDX-1509

  • Clean up on aisle 9 around the insertYourFlavourOfPageHere commons interfaces so that it doesn't pollute the rest of the project and stays somewhat sane.
  • Expose a new /manifest route for the NGSP to support NGSP import in the CLI.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@louis-bompart louis-bompart marked this pull request as ready for review February 5, 2024 17:29
@louis-bompart louis-bompart requested a review from a team February 5, 2024 17:29
@louis-bompart louis-bompart requested a review from a team as a code owner February 5, 2024 17:29
@louis-bompart louis-bompart enabled auto-merge (squash) February 5, 2024 17:29
@louis-bompart louis-bompart enabled auto-merge (squash) February 5, 2024 17:30
toofff
toofff approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@toofff toofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-bompart louis-bompart merged commit 457d82a into master Feb 5, 2024
4 checks passed
@louis-bompart louis-bompart deleted the feat/CDX-1509 branch February 5, 2024 20:41
@louis-bompart louis-bompart mentioned this pull request Feb 5, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 52.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathiery pathiery pathiery approved these changes

@dmgauthier dmgauthier dmgauthier approved these changes

@toofff toofff toofff approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louis-bompart @toofff @dmgauthier @pathiery