Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new api call in the platform client #802

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

cjun-coveo
Copy link
Contributor

Changes:

Added new client to communicate with tailgate service.
Tailgate swagger: https://platformdev.cloud.coveo.com/docs?urls.primaryName=Tailgate#/

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@mogagnon
Copy link
Contributor

Let's wait on a functional call on tailgate service before merging this, we'll probably need to add the return model as well

Copy link
Contributor

@FelixBlaisThon FelixBlaisThon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure you are aware, you are not exporting Tailgate.ts, in the index.ts file that should sit at the root of src/resources/Tailgate, so you won't have access to getWorkerCount()

@cjun-coveo
Copy link
Contributor Author

Just to make sure you are aware, you are not exporting Tailgate.ts, in the index.ts file that should sit at the root of src/resources/Tailgate, so you won't have access to getWorkerCount()

Nice catch, fixed!

@mogagnon
Copy link
Contributor

mogagnon commented Mar 6, 2024

After testing it I have some suggestion:

  1. Put the CatalogContent.ts under Catalogs/. I feel like tailgate is confusing for people that haven't work on the project.
  2. Remove the Tailgate folder and the Tailgate.ts this api is only used to debug and we should not expose it the admin-ui

@mogagnon
Copy link
Contributor

mogagnon commented Mar 7, 2024

:shipit:

@cjun-coveo cjun-coveo merged commit 289db1a into master Mar 7, 2024
4 checks passed
@cjun-coveo cjun-coveo deleted the feat/CIUG-716-new branch March 7, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants