Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipelines): add excludeAbTestTargets parameter to options #804

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feat(pipelines): add excludeAbTestTargets parameter to options #804

merged 1 commit into from
Mar 15, 2024

Conversation

aboissinot-coveo
Copy link
Contributor

Description

Add the excludeAbTestTargets parameters to the ListPipelinesOptions interface.

This property is documented in Swagger. 📖

Screenshot 2024-03-13 at 10 49 20 AM

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • My merge commit message will be conventional (See Conventional Commit)

@aboissinot-coveo aboissinot-coveo requested a review from a team March 13, 2024 14:49
@aboissinot-coveo aboissinot-coveo requested a review from a team as a code owner March 13, 2024 14:49
FelixBlaisThon
FelixBlaisThon approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@FelixBlaisThon FelixBlaisThon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboissinot-coveo aboissinot-coveo merged commit bdc96cf into master Mar 15, 2024
4 checks passed
@aboissinot-coveo aboissinot-coveo deleted the SEARCHAPI-9901/pipelines-exclude-ab branch March 15, 2024 12:14
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 53.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixBlaisThon FelixBlaisThon FelixBlaisThon approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@toofff toofff Awaiting requested review from toofff

@dmgauthier dmgauthier Awaiting requested review from dmgauthier

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboissinot-coveo @louis-bompart @FelixBlaisThon