Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add interface for catalogContent #805

Merged
merged 4 commits into from
Mar 19, 2024
Merged

fix: add interface for catalogContent #805

merged 4 commits into from
Mar 19, 2024

Conversation

mogagnon
Copy link
Contributor

@mogagnon mogagnon commented Mar 14, 2024 •
edited
Loading

Acceptance Criteria

Add interface for your new api

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@mogagnon mogagnon requested a review from a team March 14, 2024 20:29
@mogagnon mogagnon requested a review from a team as a code owner March 14, 2024 20:29
toofff
toofff approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@toofff toofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mogagnon mogagnon merged commit ea03e8f into master Mar 19, 2024
4 checks passed
@mogagnon mogagnon deleted the fix/CIUG-791 branch March 19, 2024 20:50
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 53.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@comagnan comagnan comagnan approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@toofff toofff toofff approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mogagnon @toofff @louis-bompart @comagnan @gdostie