Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(projects): add new project types #808

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat(projects): add new project types #808

merged 1 commit into from
Mar 26, 2024

Conversation

pcoelho-coveo
Copy link
Contributor

@pcoelho-coveo pcoelho-coveo commented Mar 25, 2024 •
edited
Loading

Acceptance Criteria

TSP-214

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@pcoelho-coveo pcoelho-coveo self-assigned this Mar 25, 2024
@pcoelho-coveo pcoelho-coveo marked this pull request as ready for review March 25, 2024 20:40
@pcoelho-coveo pcoelho-coveo requested a review from a team March 25, 2024 20:40
@pcoelho-coveo pcoelho-coveo requested a review from a team as a code owner March 25, 2024 20:40
@pcoelho-coveo pcoelho-coveo enabled auto-merge (squash) March 25, 2024 20:40
toofff
toofff approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@toofff toofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmorissette
jmorissette reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@jmorissette jmorissette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does everything need to go to prod together ?

Like do we have a deployment order to follow to prevent breaking change or we are good because we still have the deprecated enum values ?

@pcoelho-coveo pcoelho-coveo merged commit 2c09615 into master Mar 26, 2024
4 checks passed
@pcoelho-coveo pcoelho-coveo deleted the feat/TSP-214-types branch March 26, 2024 13:24
@pcoelho-coveo
Copy link
Contributor Author

Does everything need to go to prod together ?

Like do we have a deployment order to follow to prevent breaking change or we are good because we still have the deprecated enum values ?

I will deploy the backend now and then update the admin-ui

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 53.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorissette jmorissette jmorissette approved these changes

@toofff toofff toofff approved these changes

@gdostie gdostie Awaiting requested review from gdostie

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees

@pcoelho-coveo pcoelho-coveo

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcoelho-coveo @toofff @jmorissette