Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sources): add new source properties and sorting options #812

Conversation

ClaudineL
Copy link
Contributor

@ClaudineL ClaudineL commented Apr 5, 2024

CTCORE-9943 [PlatformClient] Update list filter interfaces and SourceModel

Added the new properties added to source service for displaying and sorting.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@ClaudineL ClaudineL requested a review from a team April 5, 2024 15:38
@ClaudineL ClaudineL requested a review from a team as a code owner April 5, 2024 15:38
Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know when the documentation will be updated accordingly?

@ClaudineL
Copy link
Contributor Author

Do you know when the documentation will be updated accordingly?

@jlevesquecoveo Is the doc team responsible for updating the API doc? What's the process for this?

@jlevesquecoveo
Copy link

jlevesquecoveo commented Apr 10, 2024

Do you know when the documentation will be updated accordingly?

@jlevesquecoveo Is the doc team responsible for updating the API doc? What's the process for this?

Yes. We run a script that pulls the specs and publish them. I will keep the doc jira as a reminder to run the script once the changes are in prod.

CTCORE-9943 [PlatformClient] Update list filter interfaces and SourceModel
@ClaudineL ClaudineL force-pushed the feat/CTCORE-9943-Update-list-filter-interfaces-and-SourceModel branch from 78437cd to a12b7b5 Compare April 10, 2024 20:43
@ClaudineL ClaudineL merged commit b328a6b into master Apr 10, 2024
4 checks passed
@ClaudineL ClaudineL deleted the feat/CTCORE-9943-Update-list-filter-interfaces-and-SourceModel branch April 10, 2024 20:45
Copy link

🎉 This PR is included in version 54.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants