Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api key): add lifetimeDuration parameter and split interface #880

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat(api key): add lifetimeDuration parameter and split interface #880

merged 1 commit into from
Oct 28, 2024

Conversation

GermainBergeron
Copy link
Member

@GermainBergeron GermainBergeron commented Oct 28, 2024 •
edited
Loading

Improved the type of the ApiKey.create call, it now only allow the parameters the backend accept
Added the lifetimeDuration parameter

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@GermainBergeron GermainBergeron force-pushed the feat/ADUI-10313-api-key-lifetime-duration branch from de94847 to 3ceeb9a Compare October 28, 2024 17:59
@GermainBergeron GermainBergeron marked this pull request as ready for review October 28, 2024 18:08
@GermainBergeron GermainBergeron requested review from a team as code owners October 28, 2024 18:08
@GermainBergeron GermainBergeron added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 999b71e Oct 28, 2024
7 checks passed
@GermainBergeron GermainBergeron deleted the feat/ADUI-10313-api-key-lifetime-duration branch October 28, 2024 18:27
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 56.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@gdostie gdostie gdostie approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon FelixBlaisThon is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GermainBergeron @gdostie @alexprudhomme