Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add exposure report to api key model #897

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: add exposure report to api key model #897

merged 1 commit into from
Dec 17, 2024

Conversation

schaoukicoveo
Copy link
Contributor

@schaoukicoveo schaoukicoveo commented Dec 17, 2024 •
edited
Loading

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@schaoukicoveo schaoukicoveo requested review from a team as code owners December 17, 2024 18:25
@schaoukicoveo schaoukicoveo added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit f396eb0 Dec 17, 2024
9 checks passed
@schaoukicoveo schaoukicoveo deleted the feature/ORG-911-exposureReport branch December 17, 2024 21:40
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 57.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

paulgerold pushed a commit that referenced this pull request Dec 19, 2024
@schaoukicoveo @paulgerold
feat: add exposure report to api key model (#897)
85a998e 
J:ORG-911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HNascimento-coveo HNascimento-coveo HNascimento-coveo approved these changes

@FelixBlaisThon FelixBlaisThon FelixBlaisThon approved these changes

@GermainBergeron GermainBergeron Awaiting requested review from GermainBergeron GermainBergeron is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme alexprudhomme is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaoukicoveo @FelixBlaisThon @HNascimento-coveo