Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update SourceType enum - CTCORE-10551 #899

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: update SourceType enum - CTCORE-10551 #899

merged 1 commit into from
Dec 18, 2024

Conversation

toofff
Copy link
Member

@toofff toofff commented Dec 18, 2024 •
edited
Loading

The SourceType enum has been evolving a lot lately, so I'm just updating it so that everyone can benefit from its evolution.

You can see the different SourceModel currently set up the GET item call of sources.

image

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@toofff toofff force-pushed the feature/CTCORE-10551-move-source-type-enum branch 3 times, most recently from 4b9da0a to a34cc11 Compare December 18, 2024 17:25
@toofff toofff marked this pull request as ready for review December 18, 2024 17:27
@toofff toofff requested review from a team as code owners December 18, 2024 17:27
GermainBergeron
GermainBergeron approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@GermainBergeron GermainBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sur I understand, we're removing values that the backend doesn't return anymore and adding a few new SourceType?

src/resources/Enums.ts Show resolved Hide resolved
@toofff toofff force-pushed the feature/CTCORE-10551-move-source-type-enum branch from a34cc11 to 2cf7469 Compare December 18, 2024 18:58
gdostie
gdostie reviewed Dec 18, 2024
View reviewed changes
src/resources/Enums.ts Outdated Show resolved Hide resolved
@toofff toofff force-pushed the feature/CTCORE-10551-move-source-type-enum branch from 2cf7469 to a033da2 Compare December 18, 2024 19:29
@toofff
feat: update SourceType enum - CTCORE-10551
2f1f20d 
- rename the GENERIC key to GENERIC_REST to match its value
- rename the MICROSOFT key to MICROSOFT_DYNAMICS to match its value
- added SourceType: SALESFORCE_SITES & SAP
- delete SourceType:
  - BOX
  - BOX_ENTERPRISE
  - DROPBOX
  - EXCHANGE
  - EXCHANGE_ENTERPRISE
  - GMAIL
  - GMAIL_DOMAIN_WIDE
  - GMAIL_SINGLE_USER
  - GOOGLE_DRIVE_SINGLE_USER
  - ONEDRIVE
  - SHAREPOINT_ONLINE
  - TWITTER2
@toofff toofff force-pushed the feature/CTCORE-10551-move-source-type-enum branch from a033da2 to 2f1f20d Compare December 18, 2024 19:41
@toofff toofff added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 2444091 Dec 18, 2024
5 checks passed
@toofff toofff deleted the feature/CTCORE-10551-move-source-type-enum branch December 18, 2024 20:21
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 57.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

paulgerold pushed a commit that referenced this pull request Dec 19, 2024
@toofff @paulgerold
feat: update SourceType enum - CTCORE-10551 (#899)
1bdf041 
- rename the GENERIC key to GENERIC_REST to match its value
- rename the MICROSOFT key to MICROSOFT_DYNAMICS to match its value
- added SourceType: SALESFORCE_SITES & SAP
- delete SourceType:
  - BOX
  - BOX_ENTERPRISE
  - DROPBOX
  - EXCHANGE
  - EXCHANGE_ENTERPRISE
  - GMAIL
  - GMAIL_DOMAIN_WIDE
  - GMAIL_SINGLE_USER
  - GOOGLE_DRIVE_SINGLE_USER
  - ONEDRIVE
  - SHAREPOINT_ONLINE
  - TWITTER2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdroulers-coveo cdroulers-coveo cdroulers-coveo approved these changes

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@gdostie gdostie gdostie approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toofff @GermainBergeron @gdostie @alexprudhomme @cdroulers-coveo