Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Dependency Review less verbose #22

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Make Dependency Review less verbose #22

merged 1 commit into from
Sep 27, 2023

Conversation

klalumiere
Copy link
Member

@klalumiere klalumiere commented Sep 25, 2023 •
edited
Loading

A comment-summary-in-pr of on-failure is a good compromise between never and always. See the
description that I copy-pasted and the documentation of the option comment-summary-in-pr. Note that GitHub's default is never.

J:IDXINFRA-1706

@klalumiere klalumiere requested review from a team as code owners September 25, 2023 22:48
@klalumiere klalumiere self-assigned this Sep 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 25, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@klalumiere
Make Dependency Review less verbose
bb806f4 
The comment summary in PR `on-failure` is a good compromise between
`never` and `always`. See [the
description](https://github.com/actions/dependency-review-action/blob/main/action.yml#L48)
that I copy-pasted and [the documentation of the option
`comment-summary-in-pr`](https://github.com/actions/dependency-review-action#configuration-options).

J:IDXINFRA-1706
@klalumiere klalumiere merged commit 440fda3 into main Sep 27, 2023
8 checks passed
@klalumiere klalumiere deleted the IDXINFRA-1706 branch September 27, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblanchette dblanchette dblanchette approved these changes

@dotboris dotboris dotboris approved these changes

@sysboy sysboy Awaiting requested review from sysboy sysboy is a code owner automatically assigned from coveo/dev-tooling-reviewers-1

@jonapich jonapich Awaiting requested review from jonapich jonapich is a code owner automatically assigned from coveo/dev-tooling-reviewers-1

@pballandras pballandras Awaiting requested review from pballandras pballandras is a code owner automatically assigned from coveo/dev-tooling-reviewers-2

@wtrep wtrep Awaiting requested review from wtrep wtrep is a code owner automatically assigned from coveo/dev-tooling-reviewers-2

@mikebaum mikebaum Awaiting requested review from mikebaum mikebaum is a code owner automatically assigned from coveo/dev-tooling-reviewers-3

Assignees

@klalumiere klalumiere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klalumiere @dotboris @dblanchette