JSUI-3539 add GitHub certifier #1992
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSUI-3539
JSUI-3539
wmannard
commented
Oct 15, 2024
wmannard
requested review from
olamothe,
fpbrault,
y-lakhdar,
alexprudhomme and
lvu285
alexprudhomme
approved these changes
Oct 16, 2024
lvu285
approved these changes
Nov 20, 2024
y-lakhdar
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSUI-3539
NOTE: Let's merge this after the JSUI October release is complete. We can see how it goes for the November release. At very worst, we can remove the new certifier section in the deployment config if something goes wrong.
The Netlify JSUI version check will wait for 180 seconds for the deployment and retry twice, giving 9 minutes in total for the deployment to be complete.
Normally the deployment should be ready in about 60 seconds.
Test with correct JSUI version:
https://github.com/coveo/search-ui/actions/runs/11354821467/job/31582861347
Test with incorrect JSUI verison:
https://github.com/coveo/search-ui/actions/runs/11355020702/job/31583515125
Test where the deployed version on Netlify was upgraded by the webhook:
https://github.com/coveo/search-ui/actions/runs/11355209362/job/31584098923
^ I first deployed an old version (2.10119.0). It was successfully updated to the current beta 2.10120.0.
Once this is merged, we'll have to start a deployment up to staging to see if this works as expected in the context of the deployment pipeline.