* Added Secret Scanning Alert call to Repository #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Dependabot Alert call to Repository * Added missing Code Scan Alert call to Repository pyi * Created Secret Scanning Alert Object * Created Dependabot Alert Object * Created Security Vulnerability Object * Created Dependency Object * Created Package Object * Fixed Code Scanning Alert object to use already existing CodeScanTool class * Remove Tool object (redundant)
* Fixed bugs discovered with tests
tbronsonCoveo
requested review from
JPLachance,
jonapich,
dblanchette,
pballandras and
wtrep
dotboris
reviewed
Apr 26, 2023
github/DependabotAlert.py
Outdated
Comment on lines
122
to
134
| def _initAttributes(self): | ||
| self._created_at = github.GithubObject.NotSet | ||
| self._dependency = github.GithubObject.NotSet | ||
| self._dismissed_at = github.GithubObject.NotSet | ||
| self._dismissed_comment = github.GithubObject.NotSet | ||
| self._dismissed_reason = github.GithubObject.NotSet | ||
| self._fixed_at = github.GithubObject.NotSet | ||
| self._html_url = github.GithubObject.NotSet | ||
| self._number = github.GithubObject.NotSet | ||
| self._security_vulnerability = github.GithubObject.NotSet | ||
| self._state = github.GithubObject.NotSet | ||
| self._updated_at = github.GithubObject.NotSet | ||
| self._url = github.GithubObject.NotSet |
There was a problem hiding this comment.
You're missing:
security_advisorydismissed_byauto_dismissed_at
Not sure if that was intentional
There was a problem hiding this comment.
Security advisory intentionnaly left out since it is a huge object and not needed for our use case.
Fixed missing dismissed_by attributes. It was missing indeed.
I added auto dismissed_at added although not used in our case.
There was a problem hiding this comment.
Sounds good. My aim here is to increase the likelyhood that this gets merged upstream eventually. But if you don't need them and they slow you down, we can go like this
github/SecretScanningAlert.py
Outdated
Comment on lines
146
to
161
| self._created_at = github.GithubObject.NotSet | ||
| self._html_url = github.GithubObject.NotSet | ||
| self._locations_url = github.GithubObject.NotSet | ||
| self._number = github.GithubObject.NotSet | ||
| self._push_protection_bypassed = github.GithubObject.NotSet | ||
| self._push_protection_bypassed_at = github.GithubObject.NotSet | ||
| self._push_protection_bypassed_by = github.GithubObject.NotSet | ||
| self._resolution = github.GithubObject.NotSet | ||
| self._resolution_comment = github.GithubObject.NotSet | ||
| self._resolved_at = github.GithubObject.NotSet | ||
| self._resolved_by = github.GithubObject.NotSet | ||
| self._secret = github.GithubObject.NotSet | ||
| self._secret_type = github.GithubObject.NotSet | ||
| self._secret_type_display_name = github.GithubObject.NotSet | ||
| self._state = github.GithubObject.NotSet | ||
| self._url = github.GithubObject.NotSet |
github/SecurityVulnerability.py
Outdated
Comment on lines
41
to
44
| def _initAttributes(self): | ||
| self._package = github.GithubObject.NotSet | ||
| self._severity = github.GithubObject.NotSet | ||
| self._vulnerable_version_range = github.GithubObject.NotSet |
There was a problem hiding this comment.
You're missing:
first_patched_version
There was a problem hiding this comment.
intentionally left out but now that I think of it, I will add it.
* fix missing attributes in SecretScanningAlert, DependabotAlert, SecurityVulnerability
dotboris
approved these changes
Apr 27, 2023
|
@jonapich, do you have a documentation, so we become autonomous at shipping this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add last missing elements for certifier
First PR was to allowed creation of v1 certifier (in progress), this will complete it.