-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .NET Core support & updated dependencies #40
Conversation
Global tool support can be enabled via setting the target framework to 2.1
I can merge the solutions together if it is needed, but I think the AppVeyor config will need altering for the .NET Core support. Edit: I haven't adjusted the main project version, so the file produced when calling |
I've merged the project files together to make them easier to manage. I've also added .NET Core 2.1 support, so global tool support should now work. All tests pass on my end, however AppVeyor still needs to be updated with the .NET Core 2.1 SDKs (should happen within a week of this comment), and the |
This would also close #28 |
This looks like it would make adding coverall support to .NET Core projects a lot easier; is there any hope this will eventually be merged? |
Not sure, there hasn't been any action on this repo in a while, so I'm not sure how much support it is still getting. I don't know if it's because the check fails that they simply haven't done anything with this (which would be really annoying, since all they need to do is at least mention that), however I know the tests pass (I did it on my machine when making this, for both .NET Framework and .NET Core), so it's purely a case of adjusting the appveyor config (since this isn't my repo, I'm not confident that I'll be able to edit it to how they'd want it, but if they just mentioned it, I can makes changes, but I also don't use appveyor, so I don't know the config from the top of my head and would need to research a little first). |
I am still maintaining this as I'm able with what little free time I have. I'll pull this down locally and see if I can spot the issue. If it's just AppVeyor being annoying or not supporting something, then I can work everything locally and get a new version published. |
@jasondeering issue is likely that |
@luvies you should be able to add this in the PR and se if it builds. |
Fix appveyor.yml and update solution VS version
Thank you @devlead for the quick fix, it would have taken me some time to properly work that out & I wouldn't have been able to test it without setting up the CI myself |
@luvies no worries, hope to use the tool soon 😉 |
I've added a second solution that contains all of the .NET Core projects, and have updated the projects in order to get it working with the new target. Unfortunately, a number of the dependencies were out of date (and it meant that they didn't have .NET Standard support), so I've had to bring them up to the latest versions so both projects work nicely together (and actually build). It also meant that I had to updated the target .NET Framework version to 4.6.2, however this shouldn't change much.
All tests pass on both targets. The
dotnet
command can be used to build and test both versions now, but Visual Studio also still works. Note, I had to delete thebin
andobj
directories for each project to allow it to build for the new .NET Framework target.I also set up the .NET Core version of the
coveralls.net
project to output in a dotnet-tool compatible format, so people using .NET Core can install the project using theDotNetCliToolReference
tag in theircsproj
. Once they do, they can usedotnet coveralls
to execute the app as normal. I have also provided the necessary config items to allow global tool support, meaning that once .NET Core 2.1 is out, you can just bump the version and it will support it.