Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Commit

Permalink
Fix build.yml so we actually run on Windows and macOS
Browse files Browse the repository at this point in the history
Right now we just run on ubuntu-latest three times.

This patch also sets the shell to bash for all `run` steps, which is
needed for Windows.
  • Loading branch information
joliss committed Aug 19, 2020
1 parent d06f2ea commit c394268
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@ name: Node CI
# Push tests commits; pull_request tests PR merges
on: [push, pull_request]

defaults:
run:
shell: bash

jobs:

# Test the build
build:
# Setup
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [ 12.x ]
Expand All @@ -33,6 +37,11 @@ jobs:
VER=`node --version`; echo "Node ver: $VER"
VER=`npm --version`; echo "npm ver: $VER"
- name: Set up Windows
run: |
npm config set script-shell "C:\\Program Files\\Git\\bin\\bash.exe"
if: matrix.os == windows-latest

- name: Install
run: npm install

Expand Down

0 comments on commit c394268

Please sign in to comment.