Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Fix failing windows ci build #591

Open
jzohrab opened this issue Aug 20, 2020 · 1 comment
Open

Fix failing windows ci build #591

jzohrab opened this issue Aug 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jzohrab
Copy link
Contributor

jzohrab commented Aug 20, 2020

Description

None of the project devs use windows, and if we enable windows in github CI things start failing.

The branch revealing the issues is in this repo, in branch fix-windows-ci

(issues uncovered from https://github.com/covidatlas/li/pull/590/files)

If a windows dev can look into these failures, that would be great. Thanks!

@jzohrab jzohrab added the bug Something isn't working label Aug 20, 2020
@jzohrab
Copy link
Contributor Author

jzohrab commented Aug 20, 2020

The very first test fails with a bad filename, it's probably something trivial:

  can crawl Excel

    √ Sandbox Found Architect project manifest, starting up
    Created test cache D:\a\li\li\zz-testing-fake-cache
    Created test report dir D:\a\li\li\zz-reports-dir
    Wrote to local cache: D:\a\li\li\zz-testing-fake-cache\excel-source\2020-08-20\2020-08-20t13_56_36.834z-default-aec8c.xlsx.gz
    Crawl excel-source: 1196.147ms
    √ sanity check.

    × Error: ENOENT: no such file or directory, open 'D:\a\li\li\zz-testing-fake-cache\D:\a\li\li\zz-testing-fake-cache\excel-source\2020-08-20\2020-08-20t13_56_36.834z-default-aec8c.xlsx.gz' (fail at: undefined)

Subsequent tests fail b/c the arc sandbox is listening on that port and isn't shut down correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant