Fix build.yml so we actually run on Windows and macOS #590
Conversation
joliss
force-pushed
the
ci
branch
3 times, most recently
from
fe8929a
to
c394268
Compare
Right now we just run on ubuntu-latest three times. This patch also sets the shell to bash for all `run` steps, which is needed for Windows.
|
So it looks like there's a whole bunch of things going wrong on Windows; see the test output on Windows. I don't think this is something I want to try and fix, especially since I don't have a Windows development box set up. Do we have any volunteers to try and fix this? Or do we just give up on the Windows build for now? |
|
Wow, huge find, thank you! |
|
One thing that occurs to me looking at this: Update: on second thought, prob not, idk! |
|
Let's give up on the Windows build for now. We don't have any devs on windows, prod isn't windows, and if we do get one who has dev experience, then that can be their first concrete task to work on. I'm running on mac with no issues during local test and dev, which is sufficient for me. Great find, @joliss . I've created a |
|
Verifying macOS ci works in a separate branch -- run details are at https://github.com/covidatlas/li/runs/1008043577?check_suite_focus=true. Opening a new PR which will focus on what works. Thanks @joliss ! jz |
|
Closing in favor of #592. |
Right now we just run on ubuntu-latest three times.
See for example https://github.com/covidatlas/li/commit/d06f2ea5fb0a6647ef42b818991d57e6cf29bcb9/checks#step:1:3, which has os = windows-latest, but is actually running on Ubuntu.
I'm assuming this PR will uncover some tests that'll fail on Windows or Mac, so perhaps we should hold off on merging it until those are fixed.