Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base): add support for Base #96

Merged
merged 8 commits into from
Nov 26, 2024
Merged

feat(base): add support for Base #96

merged 8 commits into from
Nov 26, 2024

Conversation

alfetopito
Copy link
Contributor

Summary

Add support for Base

Testing

Unit tests, manual testing

@alfetopito alfetopito self-assigned this Nov 5, 2024
@alfetopito alfetopito requested a review from a team November 5, 2024 09:34
@socket-security Socket Security
Copy link

socket-security bot commented Nov 5, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@cowprotocol/[email protected] network 0 2.87 MB cowprotocol_dev
npm/@cowprotocol/[email protected] network 0 1.39 MB cowprotocol_dev
npm/[email protected] None 0 4.25 kB sindresorhus
npm/[email protected] None 0 10.9 kB ljharb
npm/[email protected] None 0 4.9 kB bendrucker
npm/[email protected] None 0 3.06 kB bendrucker
npm/[email protected] None 0 5.92 kB bendrucker
npm/[email protected] None 0 6.73 kB bendrucker
npm/[email protected] None 0 36.7 kB gkz
npm/[email protected] None 0 60.7 kB simenb
npm/[email protected] None 0 3.17 kB cwmma
npm/[email protected] None 0 14.7 kB matteo.collina
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] None 0 187 kB terkelg
npm/[email protected] None 0 15.4 kB dougwilson
npm/[email protected] environment 0 29.5 kB rob-w
npm/[email protected] None 0 461 kB lupomontero
npm/[email protected] filesystem +1 11.8 kB mafintosh
npm/[email protected] None 0 32.9 kB google-wombot
npm/[email protected] None 0 70.7 kB ndubien
npm/[email protected] None 0 226 kB ljharb
npm/[email protected] None 0 6.96 kB lpinca
npm/[email protected] None 0 8.37 kB feross
npm/[email protected] None 0 12.8 kB davidmarkclements
npm/[email protected] None 0 6.24 kB dougwilson
npm/[email protected] environment 0 24 kB gnoff
npm/[email protected] environment 0 210 kB matteo.collina
npm/[email protected] filesystem +1 110 kB paulmillr
npm/[email protected] eval 0 4.83 kB matteo.collina
npm/[email protected] None 0 44.4 kB luin
npm/[email protected] None 0 8.85 kB bridgear
npm/[email protected] None 0 27.7 kB bridgear
npm/[email protected] None 0 241 kB rbuckton
npm/[email protected] None 0 577 kB google-wombot
npm/[email protected] None 0 49.2 kB mathias
npm/[email protected] None 0 27.8 kB benjamn
npm/[email protected] None 0 135 kB benjamn
npm/[email protected] None 0 40.4 kB ljharb
npm/[email protected] None 0 302 kB mysticatea
npm/[email protected] None 0 53.8 kB google-wombot
npm/[email protected] None 0 65.7 kB jviereck
npm/[email protected] None 0 19.5 kB analog-nico
npm/[email protected] filesystem 0 12.1 kB troygoode
npm/[email protected] unsafe 0 3.42 kB floatdrop
npm/[email protected] None 0 8.56 kB 3rdeden
npm/[email protected] None 0 4.98 kB sindresorhus
npm/[email protected] filesystem, unsafe 0 5.82 kB sindresorhus
npm/[email protected] None 0 20.3 kB lukeed
npm/[email protected] environment, filesystem 0 145 kB ljharb
npm/[email protected] None 0 2.82 kB sindresorhus
npm/[email protected] None 0 17 kB fent
npm/[email protected] None 0 9.44 kB matteo.collina
npm/[email protected] filesystem 0 17.3 kB isaacs
npm/[email protected] None 0 6.56 kB feross
npm/[email protected] None 0 4.5 MB blesh
npm/[email protected] None 0 16.4 kB ljharb
npm/[email protected] None 0 32.1 kB feross
npm/[email protected] None 0 10.2 kB ljharb
npm/[email protected] None 0 5.39 kB matteo.collina
npm/[email protected] None 0 30.1 kB bridgear
npm/[email protected] None 0 226 kB ricmoo
npm/[email protected] None 0 40.7 kB matteo.collina
npm/[email protected] None 0 15.8 kB nfriedly
npm/[email protected] None +1 45.6 kB ljharb
npm/[email protected] None 0 16.7 kB ljharb
npm/[email protected] None 0 4.03 kB wesleytodd
npm/[email protected] None 0 31.1 kB dcousens
npm/[email protected] None 0 2.56 kB kevva
npm/[email protected] None 0 2.83 kB sindresorhus
npm/[email protected] None 0 45 kB ljharb
npm/[email protected] None 0 23.2 kB ljharb
npm/[email protected] None 0 9.96 kB isaacs
npm/[email protected] None 0 6.79 kB terkelg
npm/[email protected] None 0 3.51 kB sindresorhus
npm/[email protected] filesystem 0 66.4 kB matteo.collina
npm/[email protected] filesystem 0 84.5 kB linusu
npm/[email protected] None 0 805 kB tromey
npm/[email protected] shell 0 4.05 kB mmalecki
npm/[email protected] None 0 17.4 kB matteo.collina
npm/[email protected] None 0 34.8 kB alexei
npm/[email protected] None 0 231 kB bahamat
npm/[email protected] unsafe 0 14.6 kB isaacs
npm/[email protected] None 0 5.3 kB luin
npm/[email protected] None 0 12.1 kB dougwilson
npm/[email protected] None 0 12.5 kB analog-nico
npm/[email protected] None 0 16.6 kB mscdex
npm/[email protected] None 0 14.4 kB matteo.collina
npm/[email protected] None 0 4.05 kB sindresorhus
npm/[email protected] None 0 33.5 kB ljharb
npm/[email protected] None 0 22.1 kB ljharb
npm/[email protected] None 0 22.9 kB ljharb
npm/[email protected] None 0 3 kB sindresorhus
npm/[email protected] None 0 3.05 kB sindresorhus
npm/[email protected] None 0 6.96 kB sindresorhus
npm/[email protected] filesystem 0 16.4 kB rmg
npm/[email protected] None 0 7.04 kB sindresorhus
npm/[email protected] None 0 9.18 kB ljharb
npm/[email protected] filesystem Transitive: environment +1 152 kB mafintosh
npm/[email protected] None +1 58.5 kB coreyfarrell
npm/[email protected] None 0 11 kB substack
npm/[email protected] None 0 6.59 kB dead_horse
npm/[email protected] None 0 7.92 kB dead_horse
npm/[email protected] None 0 62.9 kB matteo.collina
npm/[email protected] None 0 12.5 kB dominictarr
npm/[email protected] None 0 12.2 kB alexreardon
npm/[email protected] None 0 33.6 kB avoidwork
npm/[email protected] filesystem 0 52.9 kB raszi
npm/[email protected] None 0 2.77 kB daaku
npm/[email protected] None 0 3.5 kB sindresorhus
npm/[email protected] None 0 22.9 kB jonschlinkert
npm/[email protected] None 0 10.9 kB mikemcl
npm/[email protected] None 0 4.68 kB dougwilson
npm/[email protected] None 0 112 kB ccasey
npm/[email protected] None 0 268 kB sebmaster
npm/[email protected] shell 0 7.82 kB wmhilton
npm/[email protected] None 0 74.7 kB thomasaribart
npm/[email protected] None 0 69 kB krzkaczor
npm/[email protected] environment, filesystem, unsafe 0 216 kB jonaskello
npm/[email protected] None 0 83.5 kB typescript-bot
npm/[email protected] None 0 382 kB ajaff
npm/[email protected] environment, network 0 16.7 kB mikeal
npm/[email protected] None 0 42.1 kB chaijs
npm/[email protected] None 0 119 kB sindresorhus
npm/[email protected] None 0 18.5 kB dougwilson
npm/[email protected] None 0 13.1 kB ljharb
npm/[email protected] None 0 20 kB ljharb
npm/[email protected] None 0 20.3 kB ljharb
npm/[email protected] None 0 23.3 kB ljharb
npm/[email protected] None 0 11.4 kB jclemens24
npm/[email protected] environment, eval, filesystem 0 20.1 MB pleerock
npm/[email protected] None 0 7.47 kB dougwilson
npm/[email protected] None 0 14.9 kB ljharb
npm/[email protected] None 0 73.1 kB ethan_arrowood
npm/[email protected] environment, network, unsafe 0 1.12 MB ronag
npm/[email protected] None 0 5.01 kB google-wombot
npm/[email protected] None 0 5.05 kB google-wombot
npm/[email protected] None 0 25.7 kB google-wombot
npm/[email protected] None 0 5.98 kB google-wombot
npm/[email protected] None 0 4.79 kB ryanzim
npm/[email protected] filesystem, shell 0 13.7 kB ai
npm/[email protected] None 0 470 kB garycourt
npm/[email protected] None 0 63 kB swaagie
npm/[email protected] None 0 5.48 kB tootallnate
npm/[email protected] None 0 116 kB ctavan
npm/[email protected] environment, filesystem, unsafe 0 16.8 kB zertosh
npm/[email protected] filesystem, unsafe +1 50.7 kB oss-bot
npm/[email protected] None 0 8.75 kB dougwilson
npm/[email protected] None 0 35.8 kB dap
npm/[email protected] network 0 12.2 MB jmoxey
npm/[email protected] filesystem 0 5.8 kB daaku
npm/[email protected] None 0 9.04 MB mattiasbuelens
npm/[email protected] None 0 187 kB jmoxey
npm/[email protected] None 0 12.4 kB sebmaster
npm/[email protected] None 0 49.9 kB domenic
npm/[email protected] None 0 15 kB ljharb
npm/[email protected] environment 0 9.97 kB isaacs
npm/[email protected] None 0 10.6 kB sindresorhus
npm/[email protected] None 0 2.96 kB zkat
npm/[email protected] filesystem 0 12.2 kB gar
npm/[email protected] environment, network 0 137 kB lpinca
npm/[email protected] None 0 6.46 kB raynos
npm/[email protected] filesystem 0 23.4 kB oss-bot
npm/[email protected] None 0 14.8 kB isaacs
npm/[email protected] environment 0 660 kB eemeli
npm/[email protected] environment, filesystem 0 128 kB oss-bot
npm/[email protected] environment, filesystem 0 292 kB oss-bot
npm/[email protected] None 0 6.03 kB sindresorhus

🚮 Removed packages: npm/@cowprotocol/[email protected], npm/@cowprotocol/[email protected], npm/@cspotcode/[email protected], npm/@microsoft/[email protected], npm/@microsoft/[email protected], npm/@microsoft/[email protected], npm/@microsoft/[email protected], npm/@rollup/[email protected], npm/@rushstack/[email protected], npm/@rushstack/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@volar/[email protected], npm/@volar/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

alfetopito
alfetopito commented Nov 7, 2024
View reviewed changes
libs/repositories/src/TokenHolderRepository/TokenHolderRepositoryGoldRush.test.ts

describe('TokenHolderRepositoryGoldRush', () => {
describe.skip('TokenHolderRepositoryGoldRush', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires either a paid or a trial test account (active only for 14 days).
Enable it locally when needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, but maybe this should be in a comment in the code and not in a the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added c8d00c4

anxolin
anxolin approved these changes Nov 26, 2024
View reviewed changes
libs/repositories/src/TokenHolderRepository/TokenHolderRepositoryGoldRush.test.ts

describe('TokenHolderRepositoryGoldRush', () => {
describe.skip('TokenHolderRepositoryGoldRush', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, but maybe this should be in a comment in the code and not in a the PR

libs/repositories/src/TokenHolderRepository/TokenHolderRepositoryGoldRush.test.ts

describe('TokenHolderRepositoryGoldRush', () => {
describe.skip('TokenHolderRepositoryGoldRush', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added c8d00c4

@anxolin anxolin merged commit bb2bdb9 into main Nov 26, 2024
6 checks passed
@anxolin anxolin deleted the feat/base branch November 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfetopito @anxolin