feat: add collection for assets that free from fees #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alfetopito
reviewed
Dec 12, 2024
There was a problem hiding this comment.
One thing that's still not clear to me.
Here I only see individual assets, but no indication of pairs/groups of tokens.
The current implementation makes stable-stable trades free.
Will it change with this version, where if one of the tokens (buy or sell) includes any token from this collection, the trade will be fee free?
src/api/tax-free-asset/content-types/tax-free-asset/schema.json
Outdated
Show resolved
Hide resolved
@alfetopito 
|
alfetopito
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new collection which contains a list of assets that should be free from volume fee in CoW Swap
Add settings in CMS (staging and prod)
One or two (comma separated) token ids. If one, then this token will be free from fees in any trade. If two, then only this specific pair will be free from fees.- description totokenIdsfield in view settingsfindpermission toPublicrole