feat: allow list solver flag #48
Conversation
SolverNetwork model has an active flag that should be the only one
| @@ -41,6 +41,11 @@ | |||
| "type": "relation", | |||
| "relation": "oneToOne", | |||
| "target": "api::environment.environment" | |||
| }, | |||
| "allowListed": { | |||
There was a problem hiding this comment.
fine with me, but for me is more clear to just say "isOperating".
Also, renaming active to isWhiteListed could be a good idea. We can just add the flag, make sure they match, make the changes in CoW Swap, and then delete the old flag. I don't see anyone else uses this (maybe my spreadsheet and I can adapt it)
There was a problem hiding this comment.
The point about adding a new flag is that, at least from what I could gather from the solver's team view, it has a different connotation that what we need for the progress bar.
They set it to active when the solver has been allow-listed, even if the solver is not running for that environment.
Thus, the new flag is meant to signal that, while active remains what we expect: the solver is enabled and solving for the given network/environment.
There was a problem hiding this comment.
Well, I understood the other way around. Active was that our protocol whitelisted them, although I see why it makes sense too what you say.
This is why I was suggesting to not leave "active" to avoid confusion.
isWhiteListed --> whitelitest in the protocol.
isOperating ---> is running an instance and posting solutions
There was a problem hiding this comment.
maybe there's better names, but just think that "active" might be confusing
There was a problem hiding this comment.
Alternativelly, we don't use flags, and we just model the status: WHITE_LISTED_INACTIVE, WHITE_ACTIVE, NOT_WHITE_LISTED
There was a problem hiding this comment.
This is why I was suggesting to not leave "active" to avoid confusion.
Ah got it.
Alternativelly, we don't use flags, and we just model the status
I don't get this one. Would that be a new entity?
There was a problem hiding this comment.
I'm just suggesting an enumeration if there's only 3 possible values. A bit verbose but less error prone WHITE_LISTED_INACTIVE, WHITE_ACTIVE, NOT_WHITE_LISTED
There was a problem hiding this comment.
but probably not a good idea, and we want to separate the 2 concerns. I imagine that if this is automatically managed, the whitelisted flag is set manually, but the active is set automatically (for example, solver hasn't posted a solution in 24h)
Summary
2 changes:
allowListedto SolverNetwork modelUse this to indicate whether the given solver has been allow-listed for this network/env.
activefrom Solver modelSolverNetwork also has an
activeflag that's used to indicate whether given solver is active for network/env.This flag is a n artifact of a previous iteration of the model and should be removed.