Remove test of Solidity enum parsing

cowprotocol · Aug 15, 2024 · a467ea6 · a467ea6
1 parent 6d96620
commit a467ea6
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/test/GPv2Signing/Helper.sol b/test/GPv2Signing/Helper.sol
@@ -19,13 +19,6 @@ contract Harness is GPv2SigningTestInterface {
     {
         (, owner) = recoverOrderSigner(order, signature.scheme, signature.data);
     }
-
-    function uint8ToScheme(uint8 scheme) public pure returns (uint8) {
-        // Round trip encodes and decodes a uint8 to a Scheme and back. This is
-        // useful to make sure the code can't use an internally invalid signing
-        // scheme in its internal operations.
-        return uint8(GPv2Signing.Scheme(scheme));
-    }
 }
 
 contract Helper is Test {

diff --git a/test/GPv2Signing/RecoverOrderSigner.t.sol b/test/GPv2Signing/RecoverOrderSigner.t.sol
@@ -48,12 +48,6 @@ contract RecoverOrderSigner is Helper {
         assertEq(ethSignOwner, trader.addr);
     }
 
-    function test_reverts_for_invalid_signing_schemes() public {
-        // panic: failed to convert value into enum type
-        vm.expectRevert();
-        executor.uint8ToScheme(42);
-    }
-
     function test_reverts_for_malformed_ECDSA_signatures() public {
         vm.expectRevert("GPv2: malformed ecdsa signature");
         executor.recoverOrderSignerTest(