Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: foundry and devcontainer #111

Merged
merged 14 commits into from
Jun 4, 2024
Merged

feat: foundry and devcontainer #111

merged 14 commits into from
Jun 4, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Jun 3, 2024 •
edited
Loading

Description

This PR:

  1. Adds foundry configuration for the contracts.
  2. Configures the solidity compiler for foundry to replicate that currently used within the contracts.
  3. Adds a devcontainer containing foundry and node (for still running hardhat during the migration phase).
  4. Configures a VS Code environment for solidity development.

Test Plan

  1. Observe CI/CD continues to pass.

Related Issues

Closes #99
Closes #98

@mfw78 mfw78 added the E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details label Jun 3, 2024
@mfw78 mfw78 self-assigned this Jun 3, 2024
@mfw78 mfw78 requested a review from a team as a code owner June 3, 2024 13:24
@coveralls
Copy link

coveralls commented Jun 3, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 9354015169

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%
Totals Coverage Status
Change from base Build 9349644334: 0.0%
Covered Lines: 364
Relevant Lines: 366
💛 - Coveralls

@mfw78 mfw78 changed the title Foundry feat: foundry and devcontainer Jun 3, 2024
fedgiac
fedgiac reviewed Jun 3, 2024
View reviewed changes
fedgiac
fedgiac reviewed Jun 4, 2024
View reviewed changes
fedgiac
fedgiac reviewed Jun 4, 2024
View reviewed changes
@mfw78 mfw78 enabled auto-merge (squash) June 4, 2024 10:04
@mfw78 mfw78 merged commit cc8061f into main Jun 4, 2024
7 checks passed
@mfw78 mfw78 deleted the foundry branch June 4, 2024 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedgiac fedgiac fedgiac approved these changes

Assignees

@mfw78 mfw78

Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: foundry configuration chore: devcontainers
3 participants
@mfw78 @coveralls @fedgiac