chore: remove trade simulator #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't think we've ever made use of the trade simulator. It was an interesting way to showcase the
StorageAccessiblecontract, but had limited practical use: every time we need to simulate a trade, we just simulate a full settlement.The related code is therefore removed for the sake of simplification.
Internal discussion didn't bring up any use for it.
As mentioned in commit 5475208,
test/src/GPv2SettlementTestInterface.solwas only needed because of the trade simulator tests and can now be removed as well.Test Plan
CI.
Related Issues
Closes #122 as not needed anymore.