Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(volume-fee): do not add fee for USDC.e on arb #5119

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Nov 21, 2024

Summary

Fixes #5114

Added USDC.e (https://arbiscan.io/address/0xff970a61a04b1ca14834a43f5de4533ebddb5cc8) to the stablecoins list on Arbitrum (stablecoins are not taxed by volume-fee)

Docs update: cowprotocol/docs#431

To Test

  1. Set USDC.e/USDT swap on Arbitrum
  2. Expand price details
  • Fee FREE should be displayed

@shoom3301 shoom3301 requested review from a team November 21, 2024 08:43
@shoom3301 shoom3301 self-assigned this Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:49am
cowfi ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:49am
explorer-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:49am
swap-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:49am
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:49am

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shoom3301 shoom3301 merged commit ba11c02 into develop Nov 21, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the fix/5114 branch November 21, 2024 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been added to the docs as well?

@elena-zh
Copy link

elena-zh commented Dec 5, 2024

Has this been added to the docs as well?

Yes https://docs.cow.fi/governance/fees

@alfetopito
Copy link
Collaborator

Has this been added to the docs as well?

Yes https://docs.cow.fi/governance/fees

No, it has not
image

No mention of USDC.e for Arb1

@shoom3301
Copy link
Collaborator Author

@elena-zh
Copy link

elena-zh commented Dec 5, 2024

Has this been added to the docs as well?

Yes https://docs.cow.fi/governance/fees

No, it has not image

No mention of USDC.e for Arb1

Ooops, I've noticed that this PR has never been merged cowprotocol/docs#431
cc @shoom3301

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add USDC.e token into the list of fee-free tokens in Arbitrum
3 participants