Catch exception when adding missing tokens #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS - I reported this bug in Dune yesterday: |
Oh nice, thanks Ben! Hadn't seen that. In any case, I guess it makes sense to handle the exception within this script as well. |
|
It does, but you could also just update the query to filter out this one address until someone fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to generate the list of missing tokens, we observed that the script sometimes crashes due to ill-formed strings/addresses (e.g., addresses that do not have the right length).
This PR addresses this by catching an exception that is raised in this case; whenever the exception is raised, the token is now ignored.