Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create getting_new_routes_integrated_into_cow_protocol.md #434

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

cmagan
Copy link
Contributor

@cmagan cmagan commented Dec 3, 2024

We get many requests for integrating new routes, so it seems appropriate to have a public doc about it

Description

Changes

  • ...
  • ...

We get many requests for integrating new routes, so it seems appropriate to have a public doc about it
@cmagan cmagan requested a review from a team as a code owner December 3, 2024 10:11
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 21, 2025 0:50am

@cmagan
Copy link
Contributor Author

cmagan commented Jan 10, 2025

@harisang @cowmarketing what's missing to get this merged into the docs?

@cmagan
Copy link
Contributor Author

cmagan commented Jan 14, 2025

@harisang I think this is ready to merge


## Why integrate with CoW Protocol?

- CoW Protocol uses a unique batch auction mechanism and competition between multiple solvers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bullets seem a bit inconsistent but it is not a big deal

(meaning, some are full sentences, some are just stating features etc)

- Use the integration proposal template and make sure to add all necessary information.
- Post on CoW DAO forum, and engage with any follow-up questions.
2. **Solver Integration**
- Solver teams evaluate integration opportunity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency of "." (dots) use. Some sentences have a dot at the end and some do not

@harisang
Copy link
Contributor

@cmagan Added some minor comments. Could you have a look and once addressed, i will proceed with merging

@cmagan
Copy link
Contributor Author

cmagan commented Jan 21, 2025

@harisang reworked it a bit hopefully this address your comments

@harisang harisang merged commit 3c6ca81 into main Jan 21, 2025
4 checks passed
@harisang harisang deleted the getting_new_routes_integrated_into_cow_protocol.md branch January 21, 2025 13:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants