Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CIP-57 updates #439

Merged
merged 15 commits into from
Dec 18, 2024
Merged

Add CIP-57 updates #439

merged 15 commits into from
Dec 18, 2024
+49 −7

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Dec 11, 2024 •
edited
Loading

This PR updates the text with the changes proposed in CIP-57: https://snapshot.box/#/s:cow.eth/proposal/0x46d4fea1492207cf400fcb7a01141a7d4c730791d658cc77236941fc9eb7dccb

This PR addresses issue #436.

Note: Should be merged ONLY IF CIP is successful.

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 18, 2024 0:59am

@harisang harisang marked this pull request as ready for review December 11, 2024 23:46
@harisang harisang requested a review from a team as a code owner December 11, 2024 23:46
fleupold
fleupold reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not strictly related to the CiP but can we give more color on how to join a bonding pool? Imagine a solver wants to go through the whole process and only has the public docs at their disposal. Do they get all the information they need to complete this step?

docs/cow-protocol/reference/core/auctions/bonding_pools.md Show resolved Hide resolved
docs/cow-protocol/reference/core/auctions/rewards.md Outdated
- Arbitrum: $$\min\{0.0002 ~\textrm{ETH}, 6 ~\textrm{COW}\}$$,
- Gnosis Chain: $$\min\{0.15 ~\textrm{xDAI}, 6 ~\textrm{COW}\}$$,

where, again, the conversion from ETH and xDAI to COW is done by using an up-to-date price.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the time of ... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a clarification
329dc14

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bram-vdberg
Copy link
Contributor

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.✅ @harisang❌ @bram-vdbergYou can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

fleupold
fleupold approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, mostly nits about the bonding pool section

docs/cow-protocol/reference/core/auctions/bonding_pools.md Outdated Show resolved Hide resolved
docs/cow-protocol/reference/core/auctions/bonding_pools.md Outdated Show resolved Hide resolved
docs/cow-protocol/reference/core/auctions/bonding_pools.md Outdated Show resolved Hide resolved
docs/cow-protocol/reference/core/auctions/bonding_pools.md Outdated Show resolved Hide resolved
docs/cow-protocol/reference/core/auctions/bonding_pools.md Outdated Show resolved Hide resolved
@harisang
Copy link
Contributor Author

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
1 out of 2 committers have signed the CLA.✅ @harisang❌ @bram-vdbergYou can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

Probably you just need to post the msg as a standalone msg and not as a reply to the original error.

@bram-vdberg
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 17, 2024
@github-actions
@bram-vdberg has signed the CLA from Pull Request #439
fbb63d8
@harisang harisang merged commit a23edb6 into main Dec 18, 2024
4 checks passed
@harisang harisang deleted the cip_57_update branch December 18, 2024 00:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bram-vdberg bram-vdberg bram-vdberg left review comments

@fleupold fleupold fleupold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harisang @bram-vdberg @fleupold