Add partner fees verification query #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
harisang
commented
Sep 12, 2024
cowprotocol/accounting/rewards/mainnet/partner_fees_query_3602560.sql
Outdated
Show resolved
Hide resolved
fhenneke
requested changes
Sep 20, 2024
cowprotocol/accounting/rewards/mainnet/partner_fees_query_3602560.sql
Outdated
Show resolved
Hide resolved
cowprotocol/accounting/rewards/mainnet/partner_fees_query_3602560.sql
Outdated
Show resolved
Hide resolved
| -- {{result}} - two views of the result, one aggregated and one on a per tx basis | ||
|
|
||
| with | ||
| per_settlement_prelim as ( |
There was a problem hiding this comment.
this is probably not per settlement but per trade
Suggested change
| per_settlement_prelim as ( | |
| per_trade as ( |
There was a problem hiding this comment.
Good point. I did rename some of the tables. Let me know what you think.
Comment on lines
52
to
58
| per_settlement as ( | ||
| select * | ||
| from | ||
| per_settlement_prelim | ||
| where | ||
| raw_integrator_fee_in_eth > 0 | ||
| ), |
There was a problem hiding this comment.
To get a per settlement value you would probably need
Suggested change
| per_settlement as ( | |
| select * | |
| from | |
| per_settlement_prelim | |
| where | |
| raw_integrator_fee_in_eth > 0 | |
| ), | |
| per_settlement as ( | |
| select | |
| block_time, | |
| tx_hash, | |
| partner_recipient, | |
| sum(est_partner_revenue) as est_partner_revenue, | |
| sum(est_cow_revenue) as est_cow_revenue, | |
| sum(raw_integrator_fee_in_eth) as raw_integrator_fee_in_eth | |
| from | |
| per_trade | |
| where | |
| raw_integrator_fee_in_eth > 0 | |
| ), |
cowprotocol/accounting/rewards/mainnet/partner_fees_query_3602560.sql
Outdated
Show resolved
Hide resolved
cowprotocol/accounting/rewards/mainnet/partner_fees_query_3602560.sql
Outdated
Show resolved
Hide resolved
fhenneke
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the query 3602560 that we use to verify partner fees each week under version control