Remove prefect from deployment #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Oct 26, 2024
|
Yeap, this seems to have done it. Things work now, and both order rewards and batch rewards jobs seem to have finished properly and synced the relevant data. |
|
Too bad my approval doesn't count and you have to wait till Monday. Have fun until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the deployment is a bit messed up, as we currently have dune-sync only deployed in prod while prefect lives in staging. The plan is to migrate everything to staging, but until then, any new release issued in prod cannot work; i see these errors
stream logs failed container "batch-rewards" in pod "dune-sync-mainnet-batch-rewards-cj-..." is waiting to start: trying and failing to pull image for analytics/dune-sync-mainnet-batch-rewards-cj-...(batch-rewards)and i believe the reason is prefect. This PR removes the prefect deployment until we sort things out.
UPDATE: PR was applied and it worked but the latest run revealed another bug; PR #114 had not done a proper cleanup of the references to participation. Given it's a Saturday night and the script is still crashing, i decided to push the fix for that bug in this PR, which basically now serves as the working version of what I am tempting to deploy. We can discuss how to proceed with these on Monday