use more optimistic block range for sync #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses issue #72. At the moment the block range is computed using the minimum of the latest finalized block from production and staging and subtracting `REORG_THRESHOLD = 65`. This was done as a hot fix in #71. One problem with this approach is that having few settlements in staging blocks upload of production data to dune. This PR changes the behavior to look at the maximum block of the latest finalized blocks from production and staging subtracting `MAX_PROCESSING_DELAY = 1`. This should leave enough time for the autopilot to process settlements after finalization in staging and production.
harisang
reviewed
Feb 5, 2024
from 1 to 10 Co-authored-by: Haris Angelidakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #72. At the moment the block range is computed using the minimum of the latest finalized block from production and
staging and subtracting
REORG_THRESHOLD = 65. This was done as a hot fix in #71. One problem with this approach is that having few settlements in staging blocks upload of production data to dune.This PR changes the behavior to look at the maximum block of the latest finalized blocks from production and staging subtracting
MAX_PROCESSING_DELAY = 1. This should leave enough time for the autopilot to process settlements after finalization in staging and production.For testing we should monitor if there are settlements with missing information on dune compared to our database.