Add integration fee recipient #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side comment: it ended up being extremely annoying to pass the integration test. Hadn't connected to the database locally so was relying on github for debugging. The block/block_deadline business is quite confusing, so I need to do at least some sanity checks to convince myself everything is good. Opening an issue to address this. |
- added fee kind to order book query - added fee kind to uploaded data - added fee kind to tests
to stay consistent with the naming in appdata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one more field in the raw_order_rewards table on Dune; namely, what is the recipient of the protocol fee collected, if any, for an order.
Note that here we slightly abuse the term "protocol fee" as integrator fees are not really protocol fees, but from a solvers and backend point of view, they behave identically.