Extend Dune Sync appdata on Gnosis Chain #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Jun 28, 2024
Comment on lines
+97
to
+98
| else: | ||
| if chain == "gnosis": |
There was a problem hiding this comment.
is this equivalent to an elif?
Comment on lines
+70
to
84
| if chain == "mainnet": | ||
| return int( | ||
| # KeyError here means the query has been modified and column no longer exists | ||
| # IndexError means no results were returned from query (which is unlikely). | ||
| (await self.fetch(QUERIES["LATEST_APP_HASH_BLOCK"].query))[0][ | ||
| "latest_block" | ||
| ] | ||
| ) | ||
| return int( | ||
| # KeyError here means the query has been modified and column no longer exists | ||
| # IndexError means no results were returned from query (which is unlikely). | ||
| (await self.fetch(QUERIES["LATEST_APP_HASH_BLOCK"].query))[0][ | ||
| (await self.fetch(QUERIES["LATEST_APP_HASH_BLOCK_GNOSIS"].query))[0][ | ||
| "latest_block" | ||
| ] | ||
| ) |
There was a problem hiding this comment.
using an if .. elif ... seems clearer here, throwing an exception is the chain name is not correct.
(the pythonic way might be to use a match ... case ... case ... block)
Comment on lines
+135
to
+137
| genesis_bl = 15310317 | ||
| if chain == "mainnet": | ||
| genesis_bl = 12153262 |
There was a problem hiding this comment.
using an if .. elif ... seems clearer here, as above
bh2smith
suggested changes
Jun 28, 2024
Comment on lines
+1
to
+5
| -- https://dune.com/queries/3865197 | ||
| select | ||
| max(call_block_number) as latest_block | ||
| from | ||
| gnosis_protocol_v2_gnosis.GPv2Settlement_call_settle |
There was a problem hiding this comment.
You really should not need another query for this:
See here: https://dune.com/queries/3870399
Comment on lines
+1
to
+17
| -- App Hashes: https://dune.com/queries/3865206 | ||
| -- MIN(first_block_seen) = 15310317 | ||
| with | ||
| app_hashes as ( | ||
| select | ||
| min(call_block_number) first_seen_block, | ||
| get_json_object(trade, '$.appData') as app_hash | ||
| from gnosis_protocol_v2_gnosis.GPv2Settlement_call_settle | ||
| lateral view explode(trades) as trade | ||
| group by app_hash | ||
| ) | ||
| select | ||
| app_hash, | ||
| first_seen_block | ||
| from app_hashes | ||
| where first_seen_block > '{{BlockFrom}}' | ||
| and first_seen_block <= '{{BlockTo}}' |
|
Superseded by #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will attempt to replicate the mainnet setup in order to sync appdata from Gnosis Chain on Dune. Although wasteful, we need this data soon and as we are not very comfortable/familiar with Dune sync, this seems like the fastest way out.
This is marked as draft as it is incomplete.