Initial Confirmation ConfirmFuture Implementation
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
force-pushed
the
confirm_future
branch
from
ac43284 to
3b3ebdf
Compare
|
Closing as this was superseded by #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ConfirmFutureimplementation similar to confirmations inweb3. It addresses some issues that we ran into regarding the confirmations implementation in theweb3crate. Namely, it supports confirmations on Ganache, waiting for a transaction to be mined without extra confirmations on testnet and mainnet nodes, and polling fallback in cases where filters are not supported by the node (Infura over HTTPS for example). More information can be found here #104.This is the first step in unifying the confirmation API as described in issue #95 and a first chunk of the PR started here #105
Note that this PR just introduces the
ConfirmFuturewith unit tests and exports it but does not use it anywhere. That will be added in a future PR as it requires some refactoring of theSendFuture.Test Case
Many new unit tests!!!