Merge branch 'main' into get-input-from-traces

.github/nitpicks.yml

@@ -7,7 +7,7 @@
     Reminder: Please consider backward compatibility when modifying the API specification. 
     If breaking changes are unavoidable, ensure:
     - You explicitly pointed out breaking changes.
-    - You communicate the changes to affected teams.
+    - You communicate the changes to affected teams (at least Frontend team and SAFE team).
     - You provide proper versioning and migration mechanisms.
   pathFilter:
     - "**/openapi.yml"

crates/e2e/tests/e2e/place_order_with_quote.rs

@@ -67,6 +67,7 @@ async fn place_order_with_quote(web3: Web3) {
     let quote_response = services.submit_quote(&quote_request).await.unwrap();
     tracing::debug!(?quote_response);
     assert!(quote_response.id.is_some());
+    assert!(quote_response.verified);
 
     let quote_metadata =
         crate::database::quote_metadata(services.db(), quote_response.id.unwrap()).await;
@@ -99,9 +100,8 @@ async fn place_order_with_quote(web3: Web3) {
         &database::byte_array::ByteArray(order_uid.0),
     )
     .await
+    .unwrap()
     .unwrap();
-    assert!(order_quote.is_some());
-    // compare quote metadata and order quote metadata
-    let order_quote_metadata = order_quote.unwrap().metadata;
-    assert_eq!(quote_metadata.unwrap().0, order_quote_metadata);
+    assert_eq!(quote_response.verified, order_quote.verified);
+    assert_eq!(quote_metadata.unwrap().0, order_quote.metadata);
 }

crates/shared/src/order_quoting.rs

@@ -195,9 +195,7 @@ impl TryFrom<QuoteRow> for QuoteData {
             expiration: row.expiration_timestamp,
             quote_kind: row.quote_kind,
             solver: H160(row.solver.0),
-            // Even if the quote was verified at the time of creation
-            // it might no longer be accurate.
-            verified: false,
+            verified: row.verified,
             metadata: row.metadata.try_into()?,
         })
     }