Kill bad tokens 1 #3156
Draft
Kill bad tokens 1 #3156
+540
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
commented
Dec 12, 2024
| @@ -42,7 +42,7 @@ pub struct Detector { | |||
| hardcoded: HashMap<eth::TokenAddress, Quality>, | |||
| /// cache which is shared and updated by multiple bad token detection | |||
| /// mechanisms | |||
| cache: Cache, | |||
| cache: Arc<Cache>, | |||
There was a problem hiding this comment.
I am not very happy with having this in an Arc when Detector has to be wrapped in an Arc too. I didn't have time to think of a better solution. The cache has to be Arced because it has to be shared among solvers, and the Detector has to be wrapped in an Arc so we can box it in order to pass it as a future.
m-lord-renkse
commented
Dec 12, 2024
| } | ||
|
|
||
| impl Detector { | ||
| pub fn with_config(mut self, config: HashMap<eth::TokenAddress, Quality>) -> Self { |
There was a problem hiding this comment.
I am up for a DetectorBuilder.
m-lord-renkse
commented
Dec 12, 2024
| pub struct BadTokenDetector { | ||
| /// Whether or not the bad token detector is enabled | ||
| #[serde(default = "bool::default")] | ||
| pub enabled: bool, |
There was a problem hiding this comment.
I am not super convinced about this. But I guess we should have something like this in order to enable it without any token lists configured.
m-lord-renkse
commented
Dec 12, 2024
| } | ||
| } | ||
|
|
||
| impl Cache { | ||
| /// Creates a new instance which evicts cached values after a period of | ||
| /// time. | ||
| pub fn new(max_age: Duration, max_size: usize) -> Self { | ||
| pub fn new(bad_token_detection_cache: &BadTokenDetectionCache) -> Self { |
There was a problem hiding this comment.
maybe better to implement Copy trait and remove the pass by reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBD
Changes
TBD
How to test
TBD
Fixes
TBD