[EASY] Improve logging for submitting transactions #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
changed the title
m-lord-renkse
approved these changes
Dec 11, 2024
sunce86
approved these changes
Dec 11, 2024
MartinquaXD
changed the title
|
Requesting re-review due to non-trivial addition to the PR. |
sunce86
approved these changes
Dec 11, 2024
mstrug
approved these changes
Dec 11, 2024
| if let Some(id) = get_task_local_storage() { | ||
| tokio::task::spawn(REQUEST_ID.scope(id, future)) | ||
| } else { | ||
| tokio::task::spawn(future) |
There was a problem hiding this comment.
If the request id is not found maybe we should at least log that, as the intention of the caller of spawn_task_with_request_id() function is not fulfilled.
There was a problem hiding this comment.
Mmmh, maybe the function name is not great then. The expectation is not that there has to be a request id set. But rather to ensure that we'd use the same id if it is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a wish to associate MEV blocker request logs with transactions sent by the driver. This is currently not possible for 2 reasons:
/settlehandler spawns a new task to make sure transactions get cancelled (if needed) even when the autopilot terminates the request. Unfortunately how we pass aroundrequest_ids(which could also be used to associated these logs) is very convoluted and was overlooked here. Since the spawned task has its request_id variable not populated it generates a new id which does not match the original id.Changes
request_id,solverandmempooltype/settletask in a way that preserves the originalrequest_idReference slack thread