[TRIVIAL] Fix API error message #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API expects camelCase query parameters and parses them into snake_case Rust identifiers. Therefor the
APIactually expects the query parameterorderUidand notorder_uidwhich should be reflected in the error message.Changes
Updated error message to be correct from the perspective of the API consumer not the backend internals.
The error message also now uses
orinstead ofandto more strongly indicate that only 1 parameter is expected. This was not obvious when a user provided the argumentsorder_uidandownerand was surprised that the request returned results for different orders.