Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver participation guard e2e test #3280

Open
wants to merge 4 commits into
base: db-statistics-based-guard
Choose a base branch
from

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Feb 13, 2025

Implements e2e tests for all the solver participation guards from #3263 and #3257. Simulates the settlement failures by altering the DB. Another alternative is to use a broken MEV blocker URL, which is considered less flexible since some of the solutions need to be successfully settled to test at least the statistic-based approach.

The approach is a bit awkward due to the async nature of the guards implementation. Thinking more about the sync approach, there will still be the same behavior since a new auction is being cut while the previous one is being settled, meaning the sync approach will also allow the non-settling solver to submit one more solution before getting a ban.

@squadgazzz squadgazzz marked this pull request as ready for review February 13, 2025 21:06
@squadgazzz squadgazzz requested a review from a team as a code owner February 13, 2025 21:06
Copy link
Contributor

@mstrug mstrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dozen of repeated lines in the setup sections in each of the three tests, so it could be extracted to one function like setup().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants