Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autopilot: Add "timeout" to the settle metric #3284

Merged
merged 2 commits into from
Feb 21, 2025
Merged

autopilot: Add "timeout" to the settle metric #3284

merged 2 commits into from
Feb 21, 2025

Conversation

m-lord-renkse
Copy link
Contributor

Description

Add "timeout" to the settle metric. This allows us to differentiate when the error is caused by the driver not submitting the TX on time (submission deadline).

This allows us to have better metrics and filter it by the reason.

@m-lord-renkse m-lord-renkse marked this pull request as ready for review February 20, 2025 13:28
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner February 20, 2025 13:28
squadgazzz
squadgazzz reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the label is changed, this PR needs to be merged together with a corresponding infra PR to avoid breaking the alerting logic, right?

@m-lord-renkse
Copy link
Contributor Author

Since the label is changed, this PR needs to be merged together with a corresponding infra PR to avoid breaking the alerting logic, right?

Not at all. The metric is done in a clever way, so it only matters if we were to change the success string.

@m-lord-renkse m-lord-renkse merged commit fb9a63e into main Feb 21, 2025
11 checks passed
@m-lord-renkse m-lord-renkse deleted the specify-timeout-error-for-settle branch February 21, 2025 09:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@squadgazzz squadgazzz squadgazzz approved these changes

@mstrug mstrug mstrug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-lord-renkse @MartinquaXD @squadgazzz @mstrug