Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unbuffered transport for the Debug RPC API #3285

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

squadgazzz
Copy link
Contributor

Description

Since Alchemy is used as one of the failover providers and it doesn't support buffered debug RPC API, it is important to use unbuffered transport when sending debug_traceTransaction calls. Otherwise, this leads to failed RPC calls.

Changes

The easiest workaround is to use 2 separate transports for different purposes. The current approach is not really flexible since it is not configurable, but in order to keep it simple, this should be acceptable.

@squadgazzz squadgazzz marked this pull request as ready for review February 20, 2025 14:35
@squadgazzz squadgazzz requested a review from a team as a code owner February 20, 2025 14:35
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks correct. But I think naming and placement of comments can be improved to make the code easier to read.

@squadgazzz squadgazzz merged commit 38432ac into main Feb 21, 2025
11 checks passed
@squadgazzz squadgazzz deleted the unbuffered-rpc-debug-api branch February 21, 2025 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants