Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settlement executions API #3290

Closed

Conversation

squadgazzz
Copy link
Contributor

Description

This is a follow-up to #3289, which adds a way to retrieve the settlement executions based on the auction ids range via the orderbook API. The API remains private to avoid unexpected usage.

How to test

New DB tests. Staging manual test.

@squadgazzz squadgazzz marked this pull request as ready for review February 21, 2025 13:40
@squadgazzz squadgazzz requested a review from a team as a code owner February 21, 2025 13:40
@squadgazzz squadgazzz force-pushed the settlement-executions-api branch from 9cfb30e to 192e627 Compare February 21, 2025 18:18
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this API?
I thought the idea was to only use this for debugging purposes. In that case wouldn't it be enough to have this info in the DB without exposing it via undocumented API endpoints?

@squadgazzz
Copy link
Contributor Author

Why do we need this API?

We need to implement a CI job that combines the data from the DB with the dune query output. The API is the easiest way to fetch it. Otherwise, DB creds can be provided for the CI job.

@squadgazzz
Copy link
Contributor Author

We decided to go with the DB direct queries.

@squadgazzz squadgazzz closed this Feb 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants