Simulate: Transaction via Tenderly #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing transaction log parsing via ethers library with appropriate Contract artifacts. Namely, we introduce dependencies on @cowprotocol/contracts which contain the abi files for GPv2Settlement and iERC20 and suffice for us to decode relevant event data from settlement transactions. For us these are Transfer, Settlement and Trade. We construct Event types out of each which only keep the parts that matter for our purposes (namely TradeEvent having owner as the only relevant field).
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
bh2smith
commented
Apr 4, 2023
bh2smith
commented
Apr 4, 2023
bh2smith
force-pushed
the
simulate-settlement
branch
from
e6de2ec to
812c1e8
Compare
bh2smith
changed the title
alfetopito
reviewed
Apr 5, 2023
shoom3301
approved these changes
Apr 6, 2023
anxolin
reviewed
Apr 6, 2023
* parse tenderly simulation response * run linter
gentrexha
approved these changes
Apr 7, 2023
|
|
||
| export function isTenderlySimulationResponse( | ||
| value: any | ||
| ): value is TenderlySimulationResponse { |
There was a problem hiding this comment.
Out of curiosity: Why isn't this a boolean?
There was a problem hiding this comment.
Some context, this is called "type guards" https://www.typescriptlang.org/docs/handbook/advanced-types.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing an interface for transaction simulation and an implementation (via Tenderly).
We test a successful simulation and another with invalid credentials that returns nothing. We will eventually combine this with the content in #220 so to simulate the full call data provided by the winning solver. From within the tenderly web-action we could access the credentials from the action context like so:
However we use env vars here in out tests (not sure of a better way).