Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Pipeline #261

Merged
merged 5 commits into from
May 10, 2023
Merged

Full Pipeline #261

merged 5 commits into from
May 10, 2023

Conversation

bh2smith
Copy link
Contributor

@bh2smith bh2smith commented Apr 28, 2023

  1. Implement the following method
async function internalizedTokenImbalance(
  txData: MinimalTxData,
  db: Queryable,
  simulator: TransactionSimulator
): Promise<void> 

Which takes a transaction, database and transaction simulator to perform the full pipeline process outlined in this spec doc and illustrated in the screenshot below

  1. Write some tests for it.
  2. Update the index.ts file (i.e. the tenderly web-hook) to make use of this function.

Screenshot 2023-04-28 at 13 10 12

Concludes Phase 1 of part #177 (excluding a few follow ups).

@bh2smith bh2smith requested a review from a team April 28, 2023 17:12
Base automatically changed from manual-pipeline to slippage-v2 April 28, 2023 17:12
@bh2smith bh2smith mentioned this pull request Apr 28, 2023
40 tasks
@bh2smith bh2smith force-pushed the full-pipeline branch 2 times, most recently from 632ff2c to 3482278 Compare May 1, 2023 00:37
@gentrexha
Copy link
Contributor

Is this ready to be reviewed?

@bh2smith
Copy link
Contributor Author

bh2smith commented May 3, 2023

Is this ready to be reviewed?

Almost -- I need to add that TODO test (but I already added it in a follow up PR). Have not had time to come back to this.

@gentrexha
Copy link
Contributor

Is this ready to be reviewed?

Almost -- I need to add that TODO test (but I already added it in a follow up PR). Have not had time to come back to this.

Cool. No hurry. Just remove the Draft once ready and I'll take a look at it.

@bh2smith bh2smith changed the base branch from slippage-v2 to sim-both May 8, 2023 23:08
@bh2smith bh2smith marked this pull request as ready for review May 9, 2023 09:30
Copy link
Contributor

@gentrexha gentrexha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I still recommend waiting for a review from someone on the front-end team for more TS-specific comments.

I left some questions.

Copy link
Contributor

@gentrexha gentrexha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I still recommend waiting for a review from someone on the front-end team for more TS-specific comments.

I left some questions.

Base automatically changed from sim-both to slippage-v2 May 9, 2023 11:22
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok, just 2 comments

@bh2smith bh2smith merged commit 4114304 into slippage-v2 May 10, 2023
@bh2smith bh2smith deleted the full-pipeline branch May 10, 2023 10:47
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants