-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Pipeline #261
Full Pipeline #261
Conversation
632ff2c
to
3482278
Compare
Is this ready to be reviewed? |
Almost -- I need to add that TODO test (but I already added it in a follow up PR). Have not had time to come back to this. |
Cool. No hurry. Just remove the Draft once ready and I'll take a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I still recommend waiting for a review from someone on the front-end team for more TS-specific comments.
I left some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I still recommend waiting for a review from someone on the front-end team for more TS-specific comments.
I left some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly ok, just 2 comments
Which takes a transaction, database and transaction simulator to perform the full pipeline process outlined in this spec doc and illustrated in the screenshot below
Concludes Phase 1 of part #177 (excluding a few follow ups).