Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protocol fee calculations in sql query #401

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Remove protocol fee calculations in sql query #401

merged 7 commits into from
Sep 30, 2024

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Sep 25, 2024 •
edited
Loading

This PR proposes a significant simplification to the main batch rewards sql query. Up till now, the query was explicitly computing protocol fees in arguably a very ugly way, while this PR proposes that we start using the backend-computed values of protocol fees that are now stored explicitly in the order_execution table.

@harisang harisang marked this pull request as ready for review September 30, 2024 08:46
@fhenneke fhenneke self-requested a review September 30, 2024 16:16
fhenneke
fhenneke approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added one comment on naming within the sql query. Othewise looks good to go.

queries/orderbook/barn_batch_rewards.sql Outdated Show resolved Hide resolved
@harisang harisang merged commit 47a6a3e into main Sep 30, 2024
5 checks passed
@harisang harisang deleted the remove_protocol_fee_calculations_from_sql branch September 30, 2024 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fhenneke fhenneke fhenneke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harisang @fhenneke