New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some assertions for dataframes before merging #410

Closed

harisang wants to merge 1 commit into main from safer_handling_of_dataframes

Contributor

harisang commented Oct 24, 2024

This is an incomplete PR that adds some checks, in order to avoid cases where:

a solver address appears both in prod and barn; this has caused issues in the past
we don't compute a service fee for a solver address; this again has caused issues in the past due to a bug in the service fee query


          add some assertions for dataframes before merging

d58cc4e

Contributor Author

harisang commented Oct 29, 2024

Addressed by PR #411

harisang closed this

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet