Remove dead code #413
Merged
Remove dead code #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a list of tokens permitted for slippage was used at some point, but not anymore
the function was not used anymore in the code tests were removed as well
is has not been used at all in the last year, it might still work but might also not.
harisang
approved these changes
Nov 4, 2024
|
I am currently running payments for last week. If results coincide with what we got with main, I will merge this. |
|
I only see differences around the level of machine precision. Not sure where they are coming from, but definitely not something I am worried about. So I am merging this. We should have another look when the dry run happens on Thursday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes some code which is not used at the moment.
token_list.pyis not a concept we currently use in our accounting. We could add checks for that back into the accounting, but it looks more like a circuit breaker job than the job of the accounting.test_internal_trades.pywas testing internal trades, which is not part of the accounting anymore. It has only been testing properties which are not true anymore. Some of those tests could be refactored into tests for slippage. But for now I think it is fine to remove it. I also removed a reference intest_models.py.dataset.pywas not used at all.gap_detector.pylooks like interesting functionality. But it will probably be superseded by whatever we build for dune-sync. We have not used the functionality at least in the last year. So it should be fine to remove it.