Revert change about filtering dataframes #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
columns of some of the dataframes seem to be filtered before merging. in testing, the data frames did not actually contain columns of that form. instead of having this unnecessary and confusing code, an assert could be added to the dataframe validation a few lines before the merge.
harisang
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a change introduces in #407. The PR introduced a somewhat unrelated change to filter duplicate columns from data frames before merging.
In local testing it seems that the data frames do not actually contain such columns. Thus, the somewhat difficult to read code fragment does not have any effect.
If the code is indeed required, I would suggest restructuring it for clarity.
If it is important that this column only appears in one data frame, one could add a check to
validate_df_columns.