Restructure price fetching #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use addresses instead of token ids for price fetching - allow for arbitrary token conversions - explicitly load constants from payouts.py, to allow for changing it to use a config later
fhenneke
commented
Nov 7, 2024
harisang
approved these changes
Nov 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly restructures the price fetching for converting token amount for rewards.
eth_in_token,token_in_eth) we just provide an exchange rate for conversion between two tokens (exchange_rate_atoms). This will make it easier to add conversion between COW and the native token of the chain, as well as between XDAI and ETH.The
TokenIdabstraction still feels a bit stange as there is some overlap withTokendue to decimals. Supporting USDC seems a bit artificial since that is only used for testing and checking that decimals are correctly accounted for.Tests for price fetching were adapted accordingly. Transfers for the accounting week starting on 2024-10-29 only differ on the level of floating point precision.