Fix boolean command line options #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisang
reviewed
Nov 7, 2024
harisang
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how boolean command line options are implemented.
With this change, adding
--dry-runor--post-txor--ignore-slippageas command line argument will switch the corresponding argument toTrue. Otherwise, it is set toFalse. The implementation follows what is describet here.Before this change, adding
--dry-run Truewas supposed to switch on the dry run option. A bit surprisingly, adding--dry-run Falseor--dry-run dummyalso switched on the option as well. None of these ways to set the option are accepted with this PR. Adding--dry-runswitches the option on, not adding the option switches it off.This is a breaking change to the command line API. This PR should only be merged after adapting call sites appropriately.