Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Add additional logging #437

Merged
merged 4 commits into from
Nov 26, 2024
Merged

[Easy] Add additional logging #437

merged 4 commits into from
Nov 26, 2024

Conversation

fhenneke
Copy link
Collaborator

@fhenneke fhenneke commented Nov 22, 2024

This PR adds additional logs for

  • the block range of the accounting period
  • the COW to native token exchange rate
  • the COW reward per quote

It also adds a link to a protocol fee dashboard. The link needs to change though, since it does not seem to contain the dashboard for checking partner fees. (Or does it?) Edit: the log was removed as it is already part of the accunting dashboard.

This PR only changes logging and does not require additional testing.

- COW native token exchange rate
- reward per quote
- block range
@harisang
Copy link
Contributor

It also adds a link to a protocol fee dashboard. The link needs to change though, since it does not seem to contain the dashboard for checking partner fees. (Or does it?)

Indeed, another query is being used for partner fees: https://dune.com/queries/3602560
However, there is no need to link it as protocol and partner fees are already showing in the main dashboard. So i would probably remove this log

Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵

@fhenneke fhenneke merged commit 8149b10 into main Nov 26, 2024
5 checks passed
@fhenneke fhenneke deleted the add_logging branch November 26, 2024 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants